Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing slashes from endpoints #961

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Remove trailing slashes from endpoints #961

merged 2 commits into from
Oct 21, 2020

Conversation

raymondjacobson
Copy link
Member

Trello Card Link

n/a

Description

Sanitizes services that are registered with a trailing '/'

Services

  • Libs

Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?

Delete an option.

  • ✅ Nope

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Include log analysis if applicable.

  1. Manually ran dapp against staging consuming this version of libs

@raymondjacobson raymondjacobson requested review from hareeshnagaraj and dmanjunath and removed request for hareeshnagaraj October 21, 2020 22:02
@raymondjacobson raymondjacobson mentioned this pull request Oct 21, 2020
Merged
dmanjunath
dmanjunath reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@dmanjunath dmanjunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to add this same condition to the register function? seems like that may make stuff consistent at the source

@raymondjacobson
Copy link
Member Author

would it be possible to add this same condition to the register function? seems like that may make stuff consistent at the source

Sure, we can def do that too. The problem is though that you also need to do this because technically services can be registered w/o libs

@raymondjacobson
Copy link
Member Author

would it be possible to add this same condition to the register function? seems like that may make stuff consistent at the source

Sure, we can def do that too. The problem is though that you also need to do this because technically services can be registered w/o libs

Updated!

@raymondjacobson raymondjacobson merged commit c9d6b66 into master Oct 21, 2020
@raymondjacobson raymondjacobson deleted the rj-trailing-slash branch October 21, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanjunath dmanjunath dmanjunath approved these changes

@hareeshnagaraj hareeshnagaraj Awaiting requested review from hareeshnagaraj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raymondjacobson @dmanjunath